w3c / aria-practices

WAI-ARIA Authoring Practices Guide (APG)
https://www.w3.org/wai/aria/apg/
Other
1.21k stars 347 forks source link

Regression Tests: Enable `disclosure_navigation.js` test to scroll to element and click in `executeScript` context #3059

Closed howard-e closed 4 months ago

howard-e commented 5 months ago

Fixes #2996. The previous fix, #2997 didn't fully resolve the issue described in https://github.com/w3c/aria-practices/issues/2996#issuecomment-2200912116.

Update ../tests/disclosure_navigation.js test > "aria-current" attribute on links to scroll to link before click event and do click inside executeScript.


WAI Preview Link (Last built on Mon, 01 Jul 2024 20:50:58 GMT).


howard-e commented 5 months ago

For revieiwers, I re-ran this test locally 50 times using for i in {1..50}; do npm run regression -- -t test/tests/disclosure_navigation.js; done without any errors being thrown.

I also re-ran the regression tests for this PR in CI 10 times without any errors being thrown. Unless something changes, I feel confident that this should remove the flakiness with the test described in #2996.

css-meeting-bot commented 4 months ago

The ARIA Authoring Practices (APG) Task Force just discussed Regression test fix.

The full IRC log of that discussion <jugglinmike> Topic: Regression test fix
<jugglinmike> github: https://github.com/w3c/aria-practices/pull/3059
<jugglinmike> howard-e: This is a change related to the viewport with a specific test
<jugglinmike> howard-e: It aligns the test with others in the suite
<jugglinmike> howard-e: previously, there was some flakiness--perhaps because the click was happening while scrolling was in progress
<jugglinmike> howard-e: I could reproduce the flakiness locally with the previous version, but I couldn't reproduce it locally with this version
<jugglinmike> jongund: I'm looking at the code right now, and it looks good to me
<jugglinmike> jongund: I'll verify the fix locally and submit a review
<jugglinmike> Matt_King: Thank you!
<jugglinmike> s/you/you, jongund and howard-e/