w3c / compute-pressure

A web API proposal that provides information about available compute capacity
https://www.w3.org/TR/compute-pressure/
Other
69 stars 10 forks source link

Support workers in privacy algos #238

Closed kenchris closed 1 year ago

kenchris commented 1 year ago

Preview | Diff

wangw-1991 commented 1 year ago

Looks good to me. The discussion about workers are intersting.

kenchris commented 1 year ago

I think there is a difference between the implicit focus check for data delivery or whether a worker should be allowed access at all via permission policy. I think we can make the permission policy check separately from this PR

rakuco commented 1 year ago

I think we can make the permission policy check separately from this PR

Doesn't this (i.e. doing a permissions policy check or something else entirely separately) leave the privacy checks in windows open to being bypassed?

kenchris commented 1 year ago

Permission policy checks (set by site and embedder and rarely changed at runtimw) would normally be checked at start of observation, and unless we want to adjust at runtime, this should be fine. We could always stop observation if these are changed at runtime, but probably not worth the effort

rakuco commented 1 year ago

Yeah, I usually see those checks when an object is constructed or a resource will be acquired.

Before lgtm'ing this PR, I just want to make sure that it's not a problem that a window which would normally fail to receive new data because of a failed "may receive data" check can receive said data given the conditions described in https://github.com/w3c/compute-pressure/pull/238#discussion_r1358224777.

kenchris commented 1 year ago

I don't consider that a problem, but see it as implicit focus. There is an iframe with implicit focus relaying that to the shared worker

rakuco commented 1 year ago

OK then. Let's go!

kenchris commented 1 year ago

@himorin build is failing as https://respec.org/w3c/groups/ isn't loading!

himorin commented 1 year ago

@himorin build is failing as https://respec.org/w3c/groups/ isn't loading!

some other colleagues has reported on that, and someone in W3C is contacting them. so, please wait a bit for further update.