w3c / json-ld-api

JSON-LD 1.1 Processing Algorithms and API Specification

https://w3c.github.io/json-ld-api/

Other

77 stars 31 forks source link

RDF to Object conversion (closing #555) #619

Open anatoly-scherbakov opened 3 weeks ago

anatoly-scherbakov commented 3 weeks ago

Why

Trying to solve #555.

What

Clarify what we do when can't serialize a number from RDF into JSON.

Preview | Diff

anatoly-scherbakov commented 3 weeks ago

I don't think I can invite reviewers to this PR :thinking: @pchampin @gkellogg

gkellogg commented 3 weeks ago

I don't think I can invite reviewers to this PR 🤔 @pchampin @gkellogg

I'll look at your permissions, you should have full permissions on this and other repos.

gkellogg commented 3 weeks ago

@anatoly-scherbakov, if you can create branches at json-ld-api rather than on your own fork, it is easier for others to collaborate.

gkellogg commented 3 weeks ago

As an alternative, we may treat these as error conditions, which is what JCS does.

3.2.2.3. Serialization of Numbers ... Note: Since Not a Number (NaN) and Infinity are not permitted in JSON, occurrences of NaN or Infinity MUST cause a compliant JCS implementation to terminate with an appropriate error.

davidlehn commented 3 weeks ago

Can you please replace the emoji in the commit titles with words.

anatoly-scherbakov commented 6 days ago

@TallTed created a separate issue about the version of the IEEE754 standard we refer to: https://github.com/w3c/json-ld-api/issues/620

anatoly-scherbakov commented 6 days ago

@gkellogg do you mean we could convert them to JSON Strings instead of raising a JSON-LD processing error?

anatoly-scherbakov commented 6 days ago

GitHub tells me that

You're not authorized to push to this branch. Visit https://docs.github.com/repositories/configuring-branches-and-merges-in-your-repository/managing-protected-branches/about-protected-branches for more information.

Not sure why though, it might be related to the fact that I opened it in my fork.