search

w3c / spec-prod

GitHub Action to build ReSpec/Bikeshed specs, validate output and publish to GitHub pages or W3C
https://w3c.github.io/spec-prod/
MIT License
34 stars 21 forks source link

“Could not find Chrome”—Broken by latest spec-prod update? #185

Closed frivoal closed 5 months ago

frivoal commented 5 months ago

Things used to work, but now they don't:

Compare:

There was no change on my side. I suspect the culprit is https://github.com/w3c/spec-prod/commit/60b3790b5f8a1606d2f0d99c157e83b444c80416

frivoal commented 5 months ago

Or maybe it's something else? Seems similar to https://github.com/w3c/spec-prod/issues/179

sidvishnoi commented 5 months ago

I think I should stop using PUPPETEER_EXECUTABLE_PATH env var altogether (We try to existing google-chrome executable where possible). It'll cause a performance hit, but at least it won't break. Will investigate further..

sidvishnoi commented 5 months ago

@frivoal Should be fine now.

frivoal commented 5 months ago

Thanks, that worked.