search

w3c / vc-data-integrity

W3C Data Integrity Specification
https://w3c.github.io/vc-data-integrity/
Other
42 stars 19 forks source link

Define ControllerDocument class. #320

Closed msporny closed 6 days ago

msporny commented 1 week ago

This PR is an attempt to address issue https://github.com/w3c/vc-data-integrity/issues/322 by defining a ControllerDocument class.

/cc @filip26

iherman commented 1 week ago

The PR is incomplete, because the diagram must be updated as well and. It is also a question whether the domain of the "controller" property shouldn't be specified as a union (ie, logical 'or') for a controller document class and the verification method class.

@msporny I think I should take it over, because I have more practice in creating/changing the diagram. I will clone your branch and take it from there if you are fine with it.

msporny commented 1 week ago

It is also a question whether the domain of the "controller" property shouldn't be specified as a union (ie, logical 'or') for a controller document class and the verification method class.

I don't think we should limit the domain just yet... controller might make sense in many more use cases.

@msporny I think I should take it over, because I have more practice in creating/changing the diagram. I will clone your branch and take it from there if you are fine with it.

Yes, please take it over @iherman ... and thank you! :)

iherman commented 1 week ago

It is also a question whether the domain of the "controller" property shouldn't be specified as a union (ie, logical 'or') for a controller document class and the verification method class.

I don't think we should limit the domain just yet... controller might make sense in many more use cases.

@msporny I think I should take it over, because I have more practice in creating/changing the diagram. I will clone your branch and take it from there if you are fine with it.

Yes, please take it over @iherman ... and thank you! :)

Done.

msporny commented 6 days ago

Editorial, multiple reviews, changes requested and made, no objections, merging.