search

w3c / vc-data-model-2.0-test-suite

W3C Verifiable Credentials v2.0 test suite
https://w3c.github.io/vc-data-model-2.0-test-suite/
Other
11 stars 11 forks source link

Remove `checks` option in favor of loading from implementation configs. #97

Closed BigBlueHat closed 3 weeks ago

BigBlueHat commented 1 month ago

@PatStLouis @BigBlueHat so DB needs checks: ['proof'] but other implementers might not need that option and further options.checks has not be in the VC API for awhile so the best way to handle this is to add options.checks to the DB implementation and do something like this:

https://github.com/w3c-ccg/data-integrity-test-suite-assertion/blob/6d61d0f3940694edb12437bcb0f457a8b7cb56cb/assertions.js#L25-L46

How to handle this situation in the bitstring status list suite is another issue as those tests will probably need us to expose a second verify with the correct checks for our verifier.

_Originally posted by @aljones15 in https://github.com/w3c/vc-data-model-2.0-test-suite/pull/92#discussion_r1693550614_

BigBlueHat commented 1 month ago

https://github.com/w3c/vc-test-suite-implementations/pull/52

BigBlueHat commented 1 month ago

From @aljones15 in https://github.com/w3c/vc-data-model-2.0-test-suite/pull/92#discussion_r1698999986:

@BigBlueHat so the DB verifier now has the checks in the options here: https://github.com/w3c/vc-test-suite-implementations/blob/9a014669b6f62ed9c1a920ef9e054c510abefe6c/implementations/DigitalBazaar.json#L82-L91

so you can now pass the verifier's implementation specific options to each verifier which might result in failure or more success LMK.