w3c / w3c-api

The W3C API
https://w3c.github.io/w3c-api/
214 stars 92 forks source link

“/versions/{date}/predecessors” and “/versions/{date}/successors”: property names in “_links” and “_embedded” are not coherent #72

Closed tripu closed 7 years ago

tripu commented 7 years ago

After the changes in #34 (predecessor-version and successor-version), the name of the arrays returned are not consistent.

For example:

{
  "_links": {
    "predecessor-version": [
      {
      }
    ]
  },
  "_embedded": {
    "versions": [
      {
      }
    ]
  }
}

Shouldn't versions above be predecessor-version, too?

I think some clients (eg, node-w3capi) operate under the assumption that those two IDs are always the same, and it would be nice not having to make and exception in the code just for these two cases.

jean-gui commented 7 years ago

@deniak agreed to look into it

tripu commented 7 years ago

Any progress with this one…?

deniak commented 7 years ago

Not yet @tripu. I'll try to tackle that issue this week.

deniak commented 7 years ago

should be fixed now