Closed SteveALee closed 1 year ago
SteveALee
commented
2 years ago @michael-n-cooper I noticed a couple of other possible issues
shawna-slh
commented
2 years ago Hey @SteveALee I can't tell if there are still open issues, or if this is ready for Michael?
From my quick QA, the pager now gets the scrollbar when need on all the Understanding pages.
In issue 2 you said:
I saw the scrollbar whenever hover ove the pager so suspect a width bug somewhere
I haven't been able to reproduce that in Vivaldi or Firefox. Is it fixed or still an issue? If still an issue, would you be comfortable with that being milestone level 4 that we might not get done before roll out?
from above:
techniques pager doesn't seem to be working at all
We decided not to implement a "pager" in the techniques, since users pretty much never "walk" the techniques. So for now that area has only "All Techniques". For later enhancement we might add the categories, but that is very low priority for later.
the current guideline in the pager was highlighted as if it is a tab. needed to remove the active state,
looks to me like you go that fixed!?!
If good to go, please comment so, and re-assign to Michael. Thanks!
SteveALee
commented
2 years ago Left assigned to me due to scrollbar issue I saw. But as you cannot repo I'm good.
I'd did a global fix for pager highlight, even though not strictly required as I left details for fix in source.
Assigning over to Michael.
SteveALee
commented
2 years ago Oops github mobile app doesn't let me assign
@michael-n-cooper sorry for large difference due to "active" change. Hopefully you can do a different from before.
✅ Deploy Preview for wai-wcag-redesign ready!
Toggle QR Code...
Use your smartphone camera to open QR code link.
To edit notification comments on pull requests, go to your Netlify site settings.