w3c / webappsec-secure-contexts

WebAppSec Secure Contexts
https://w3c.github.io/webappsec-secure-contexts/
Other
33 stars 28 forks source link

CI: Autopublish using GitHub Actions + spec-prod #91

Closed sideshowbarker closed 3 years ago

marcoscaceres commented 3 years ago

do we still need the make file?

sideshowbarker commented 3 years ago

do we still need the make file?

I guess not — now deleted

marcoscaceres commented 3 years ago

Woot! the system works. Bikeshed is upset.

marcoscaceres commented 3 years ago

@sideshowbarker, Bikeshed is complaining for the right reasons:

   LINE ~514: Multiple possible 'environment' dfn refs.
680
      Arbitrarily chose https://html.spec.whatwg.org/multipage/infrastructure.html#blob-url-entry-environment
681
      The following refs show up multiple times in their spec, in a way that Bikeshed can't distinguish between. Either create a manual link, or ask the spec maintainer to add disambiguating attributes (usually a for='' attribute to all of them).
682
      spec:html; type:dfn; for:/; text:environment
683
        https://html.spec.whatwg.org/multipage/infrastructure.html#blob-url-entry-environment
684
        https://html.spec.whatwg.org/multipage/webappapis.html#environment
685
      LINE ~518: Multiple possible 'environment' dfn refs.
686
      Arbitrarily chose https://html.spec.whatwg.org/multipage/infrastructure.html#blob-url-entry-environment
687
      The following refs show up multiple times in their spec, in a way that Bikeshed can't distinguish between. Either create a manual link, or ask the spec maintainer to add disambiguating attributes (usually a for='' attribute to all of them).
688
      spec:html; type:dfn; for:/; text:environment
689
        https://html.spec.whatwg.org/multipage/infrastructure.html#blob-url-entry-environment
690
        https://html.spec.whatwg.org/multipage/webappapis.html#environment
691
       ✔  Successfully generated, with 2 linking errors
692
    [INFO] Finding relevant assets…
693
      Local assets to be copied: []
694
      Remote assets to be downloaded: []
695
    Copying 0 local files…
696
    Downloading 0 remote files…
697
    $ ls -R
698
      .:
699
      index.html
700
  [INFO] Build bikeshed document "index.bs" (w3c)…
701
    $ bikeshed --die-on=fatal spec "index.bs" "index.bs.built.html" --md-shortname="secure-contexts" --md-specStatus="CRD" --md-date="2021-09-07" --md-previous-version="https://www.w3.org/TR/2016/CR-secure-contexts-20160915/"
702
      FATAL ERROR: Unknown metadata key "Specstatus". Prefix custom keys with "!".
703
       ✘  Did not generate, due to fatal errors
704
    Failed
705
  Error: Process completed with exit code 2.
marcoscaceres commented 3 years ago

FATAL ERROR: Unknown metadata key "Specstatus". Prefix custom keys with "!".

sideshowbarker commented 3 years ago

FATAL ERROR: Unknown metadata key "Specstatus". Prefix custom keys with "!".

Yeah I don’t understand that error — that Specstatus is something that spec-prod added, as far as I can see

marcoscaceres commented 3 years ago

Ah, maybe it should "Status" over on the yaml file... my bad!

sideshowbarker commented 3 years ago

Ah, maybe it should "Status" over on the yaml file... my bad!

no worries — easy to fix :)

marcoscaceres commented 3 years ago

WDYT we use https://wpt.fyi/results/secure-contexts?label=experimental&label=master&aligned for the implementation report?

marcoscaceres commented 3 years ago

Or just: https://wpt.fyi/results/secure-contexts

sideshowbarker commented 3 years ago

Or just: wpt.fyi/results/secure-contexts

Yup, let’s go with that

Also the Issue Tracking addition

You gonna make the updates? Or should I?

marcoscaceres commented 3 years ago

Could you please do it. I haven't checkout out the repo 🥴

marcoscaceres commented 3 years ago

(I'll back-seat-driver make comments tho! it will be awesome)

sideshowbarker commented 3 years ago

Could you please do it. I haven't checkout out the repo 🥴

Ok, yeah, I will after a bit. I'm on from my phone right now

sideshowbarker commented 3 years ago

After merging, a bunch more errors for stuff that as far as I can see, Bikeshed/spec-prod should be adding automatically, based on the Status value.

https://github.com/w3c/webappsec-secure-contexts/runs/3531636253#step:3:670