w3c / webextensions

Charter and administrivia for the WebExtensions Community Group (WECG)
Other
605 stars 56 forks source link

GetPartitionKey updates #712

Closed aselya closed 2 weeks ago

aselya commented 1 month ago

When implementing the getPartitionKey api, there were two issues that I felt should be updated in the proposal.

The first is removing the ability to allow for just a frameId to be used. Allowing this requires the browser to make an assumption on the intended tab which is not explicitly stated in the proposal and could lead to inconsistent behavior between browsers.

In chromium there are cases where the CookiePartitionKey of a cookie can be unserializable (if it's got a nonce or the topLevelSite is opaque). The API should return an error in this case to ensure that we are only returning valid keys with this method key.

Rob--W commented 2 weeks ago

Can I squash and merge or would you like to make more changes?

aselya commented 2 weeks ago

@Rob--W, feel free to squash and merge.