Added photo privacy and improved i18n

w7cook / OpenBook

a project to create a basic social networking site

http://www.cs.utexas.edu/~wcook/Courses/devclass/index.htm

25 stars 20 forks source link

Added photo privacy and improved i18n #267

Closed jtessler closed 12 years ago

jtessler commented 12 years ago

Now only people who have access to any photo may view it. Otherwise, they receive a "photo not found" error.

Also changed the inheritance structure of Photo, making it extend Commentable instead of Post. This fixes issue #231 and will better integrate with the new timeline implementation.

And... photo tests are still green!

ProCynic commented 12 years ago

Looks fine to me.

jtessler commented 12 years ago

There seems to be a problem with the default profile picture now... Since no user is actually friends with the default user, they can't access that smiley face. This is an example of why that implementation choice worried me. Any ideas, @laurenyew?

I'll experiment with hardcoding the default user in the visibility method. However, I find this approach kinda ugly...

laurenyew commented 12 years ago

I'll look into it.

ProCynic commented 12 years ago

make the default profile pic have visibility public

jtessler commented 12 years ago

Good call, @ProCynic. Fixed now.