wadpac / GGIR

Code corresponding to R package GGIR
https://wadpac.github.io/GGIR/
Apache License 2.0
94 stars 60 forks source link

Issue1039 full qqq error edits jairo #1058

Closed jhmigueles closed 6 months ago

jhmigueles commented 7 months ago

Here some edits to PR 1045. I have defined the MM windows based on the number of epochs expected in each day rather than on the nightsi object. In that way we do not depend of the nights to define the MM days that, by definition, are separated at dayborder. This maybe does not have any influence in most scenarios, but still it could be relevant to really have all days (valid and not valid) in the fullday report (QC folder).

Also, I suspect that if a given night is not detected or in the very rare (but still possible) scenario that a participant do not sleep during a full MM window, this way of defining the days makes more sense (I don't have the data to test this though).

Checklist before merging:

vincentvanhees commented 6 months ago

I don't have the data to test this though

The data I used was the UKBiobank test cwa file as referenced in issue that the PR is based on: #1039

vincentvanhees commented 6 months ago

@jhmigueles can you confirm that this work on the UK Biobank test file from #1039?

UPDATE: I am now testing this, so no need to test...