Pub/sub for the tracker

wafflesfm / batter

It makes Waffles.

Other

83 stars 18 forks source link

Pub/sub for the tracker #35

Open ghost opened 11 years ago

ghost commented 11 years ago

Whenever changes are made to certain things, the tracker needs to be notified as per kotokoko/chihaya#2. This includes:

Torrent creation/deletion/stats coefficient modification
User creation/deletion/tracker permission modification
Whitelist modification
Settings modification (e.g. global freeleech)

Unless anyone is opposed, I suggest we use redis for this as it will be in the tech stack already.

superbobry commented 11 years ago

Why Redis? we can use ZMQ, which is one level bellow Redis and has the same PUBSUB functionality or just use a long-living connection with Go-tracker.

ghost commented 11 years ago

"as it will be in the tech stack already" and it's super easy. ØMQ would introduce a new dependency (which would be fine with me, but feels unnecessary), and doing a custom protocol as per "long-living connection with Go-tracker" would be extra work and be annoying to manage if a multi-tracker system was implemented.

Is there any reason to not use redis for this?

superbobry commented 11 years ago

Nope, Redis is fine, if we already use it (or plan to) for something else.

jzelinskie commented 11 years ago

The tracker is approaching a point where we should be beginning to consider our message queue. We are indeed currently using redis for storage. However, I do believe that half-assing the PUB/SUB functionality would be poor if we were truly trying to create something that can also be used outside of just Batter. While I've only looked into things a little, I'd prefer ZMQ to redis. Not every deployment of the tracker will be using redis and Batter.