search

wagnerwagner / merx

Merx is a plugin to create online shops with Kirby.
https://merx.wagnerwagner.de
102 stars 10 forks source link

Compatibility with stripe-php version 7 #16

Closed acabrkic closed 4 years ago

acabrkic commented 4 years ago

Hello, we are using PHP 7.4 and when we install merx 1.4.0 rc-1 via composer, it says that it is compatible only with stripe-php packages 6.28^ and not compatible with php-stripe 7. This is not a big problem, but there is a line in ApiRequestor.php (line 402) that uses array_key_exists('request-id', $rheaders) and this does not work in php 7.4 as $rheaders is an object, so it is necessary to say (array)$rheaders . This is fixed in stripe-php 7.

Will merx be compatible with stripe-php ^7.0 soon?

vitamin2ag commented 4 years ago

looking also forward to this.

tobiasfabian commented 4 years ago

Thanks for your feedback.

I’ll look into that this week.

acabrkic commented 4 years ago

https://github.com/stripe/stripe-php/issues/827 this is the link to the problem, sorry I forgot to mention it

tobiasfabian commented 4 years ago

Hey @acabrkic and @vitamin2ag,

I’ve upgraded the stripe composer module to 7.22 and experienced no issues. There is a pre-release: https://github.com/wagnerwagner/merx/releases/tag/1.4.1-rc.1

acabrkic commented 4 years ago

@tobiasfabian This fixed it, thank you :)