search

wagtail-nest / wagtail-bakery

A set of helpers for baking your Django Wagtail site out as flat files.
MIT License
179 stars 40 forks source link

Fix support for Django 4.0 and update test matrix #73

Closed Stormheg closed 1 year ago

Stormheg commented 1 year ago

This PR supersedes #72, commits retained because the original author deserves the attribution. Thanks for setting this in motion @AetherUnbound!

This PR updates the django-bakery dependency to 0.13.1 which includes support for Django 4.0. This means there is nothing holding us back anymore from supporting Django 4.0 and higher.

I've fixed the remaining compatibility issues with Django 4 and updated the testing matrix to the latest supported Django / Python / Wagtail versions.

Notably, this PR drops support for:

Support for the following Django / Python / Wagtail versions has been added:

All tests pass for me locally but I have not given this a test drive in a real project. We should verify everything still works as expected before making a new release.

AetherUnbound commented 1 year ago

Thanks so much @Stormheg! 😄 Is there any chance you could publish a release candidate for this? I'd love to test it out on the site I help run to see if it works before a full version release 🙂

Stormheg commented 1 year ago

Hi @AetherUnbound, I'd like to get a sanity-check / review from another core team member in first before publishing a release candidate.

If you want to, you could start testing this right now from my branch. Just pip install git+https://github.com/Stormheg/wagtail-bakery.git@chore/django-4x-compat.

Keen to hear about any issues you might encounter!

AetherUnbound commented 1 year ago

Tested this on our project, the build command we use for testing didn't raise any errors! https://github.com/pycascades/pycascades-cms/actions/runs/3302171649/jobs/5448653445

Stormheg commented 1 year ago

Thanks for the review @zerolab 🙏

@AetherUnbound great to hear you are not encountering any issues!

There are some things in #74 I'd like to see in to the next release. Mostly some readme changes and a few setup.py tweaks that are visible on PyPI. Without committing to a timeline, you can expect a release 'soon'.

Stormheg commented 1 year ago

@AetherUnbound this is now released in 0.6.0!

AetherUnbound commented 1 year ago

Incredible, thank you!