search

waku-org / nwaku

Waku node and protocol.
Other
203 stars 54 forks source link

fix: remove superfluous negentropy link #3022

Closed SionoiS closed 2 months ago

SionoiS commented 2 months ago

@NagyZoltanPeter noticed some weird behavior for negentropy bindings. I removed this line that was a remnant of the old bindings.

github-actions[bot] commented 2 months ago

You can find the image built from this PR at

quay.io/wakuorg/nwaku-pr:3022

Built from 6634c717bb7fe04f1768988f2d1b1a7f56c26b32

NagyZoltanPeter commented 2 months ago

Honestly with my try on same change still got weird error of missing references while building docker image....

SionoiS commented 2 months ago

Honestly with my try on same change still got weird error of missing references while building docker image....

I did too but then it magically resolved itself after a couple tries... :shrug: At least we know it's superfluous?

NagyZoltanPeter commented 2 months ago

@SionoiS : This can be closed without merge. My PR that made negentropy static linked overrides this.