waku-org / nwaku

Waku node and protocol.

Other

201 stars 53 forks source link

chore(networkmonitor): add missing field on RlnRelay init, set default for num of shards #3136

Closed vpavlin closed 1 month ago

vpavlin commented 1 month ago

Description

This PR fixes NetworkMonitor to work with latest underlying implementation of protocols.

Changes

[ ] Add missing onFatalErrorAction
[ ] set default number of shards to 8 (to match Waku Network and avoid requiring the arg)

github-actions[bot] commented 1 month ago

This PR may contain changes to configuration options of one of the apps.

If you are introducing a breaking change (i.e. the set of options in latest release would no longer be applicable) make sure the original option is preserved with a deprecation note for 2 following releases before it is actually removed.

Please also make sure the label release-notes is added to make sure any changes to the user interface are properly announced in changelog and release notes.

github-actions[bot] commented 1 month ago

You can find the image built from this PR at

quay.io/wakuorg/nwaku-pr:3136

Built from 287a48dd5e8afb19359cec0a45519296c9591f40