waku-org / nwaku

Waku node and protocol.

Other

201 stars 53 forks source link

chore: Enhancement on building nph and made it available naturaly on the path #3152

Closed NagyZoltanPeter closed 3 weeks ago

NagyZoltanPeter commented 4 weeks ago

Description

Due that vscode nph extension is taking nph binary from the path, to avoid possible discrepancies - maybe of having other nph version avail from somewhere else - this chore aims to build nph binary only if needed and move it next to nim binary - into vendor/nimbus-build-system/vendor/Nim/bin/ directory, which is inherently added to the path with the .env.sh script.

Changes

Only Makefile changes

[x] build-nph target only executes if nph binary not exists
[x] built nph binary moved next to used nim binary under vendor inside repo
[x] make update will also build nph binary for vscode extension convenience.

github-actions[bot] commented 4 weeks ago

You can find the image built from this PR at

quay.io/wakuorg/nwaku-pr:3152

Built from 4bdd2c4a65ccc86f023b1ad2fb497c7e4045f0ef