chore: naming connect procedure

[gabrielmer]

Description

Looking deeper at the code, I noticed that the connectRelay procedure uses the nim-libp2p connect procedure that connects to a node without setting a protocol. connectRelay was a misnomer and it's more correct to call itconnectPeer

Changes

• [x] renaming connectRelay to connectPeer
• [x] removing checks for Relay being configured before calling connectPeer
• [x] in connectPeer, add peer if it's not found in the peer store instead of looking specifically for Waku Relay's codec

[github-actions[bot]]

You can find the image built from this PR at

quay.io/wakuorg/nwaku-pr:3157

Built from 146097da23be23f0100b078f1193de877e8972a2

[Ivansete-status]

Thanks for that! Nevertheless, I think is interesting having a more descriptive proc name because connect is too generic and it difficult the implementation lookup. I'm more keen on longer descriptive proc name than shorter/generic proc names such as send, put, etc :)

[gabrielmer]

Thanks for that! Nevertheless, I think is interesting having a more descriptive proc name because connect is too generic and it difficult the implementation lookup. I'm more keen on longer descriptive proc name than shorter/generic proc names such as send, put, etc :)

Makes sense! I updated it to connectPeer instead :)

Thank you!