Add parameter 'type' to custom type 'harbor_registry' - Githubissues

walkamongus / puppet-harbor

Puppet Harbor module

https://forge.puppet.com/walkamongus/harbor

4 stars 7 forks source link

Add parameter 'type' to custom type 'harbor_registry' #26

Closed entasisj closed 4 years ago

entasisj commented 4 years ago

Added parameter 'type' to resource/custom type 'harbor_registry' in order to define the type of the registry endpoint, e.g. 'harbor', 'gitlab'. Set the default value of new parameter 'type' to previously hard-coded value 'harbor'. In general split much code into small methods in order to allow reuse and remove duplicated code, and improve readability and understanding.

Note that this branch bases on branch of pull request #25.

Additionally: In self.instances():

resolved issue in when calling map() on nil object which is returned by api_instance.registries_get() if there are no registries.
explicitly convert Boolean 'insecure' as member of SwaggerClient.Registry to Symbol.

In create():

always explicitly convert Symbol value of resource's 'insecure' to Boolean value for 'insecure' member of SwaggerClient::Registry.