search

walle89 / SwedbankJson

Unofficial API client for the Swedbank's and Sparbankerna's mobile apps in Sweden.
MIT License
75 stars 14 forks source link

Support QR-codes and bankid on different device #43

Closed matthiaspalmer closed 3 years ago

matthiaspalmer commented 3 years ago

Support for initiating authentication with bankid on different device and also a method for getting the PNG with the QR code.

walle89 commented 3 years ago

I have new read the code, nice work!

However I think there is a more simple solution to do a get request that supports both Json and bindary content in the response buy doing a check of the content-type in sendRequest method. Also I think ~fetchQrCode()~ getChallengeImage() is a better name witch describes what it actually doing. I will probably do these changes, meaning that much of your code will not be left when I'm done with it. But I will later merge this pull request as is anyway, to make sure that you get at least the credit for the main idea and the heavy work in git history. I will probably also need to change related documentation.