search

walmartlabs / hula-hoop

Server-side rendering components for Thorax + Hapi stacks.
Other
6 stars 11 forks source link

Start of migrate to hapi 8 #10

Closed geek closed 9 years ago

kpdecker commented 9 years ago

Are the cache changes the only things in here that are not backwards compatible with 6? We should consider the backward compatibility of the API to some extent so it might be useful to land a PR that makes all of the backwards compatible changes while still testing against 6 and then we can look at the non-compatible (from the hula hoop API's perspective) as a distinct task.

geek commented 9 years ago

Are you trying to have a shared cache, is that the point of setting the client ajax.cache property in the test?

kpdecker commented 9 years ago

The fruit-loops API expects the cache to be passed into it. It does not need to be shared, more that fruit-loops was trying to avoid explicit dependencies on hapi so the catbox cache was passed in as a work around.

There are unpublished changed that @Candid made in walmartlabs/fruit-loops#52 that may be required to make everything pass under 8.

kpdecker commented 9 years ago

@geek you still looking at this?

geek commented 9 years ago

@kpdecker haven't been looking into it lately :/

nvcexploder commented 9 years ago

@geek and @kpdecker : need me to check this out?

kpdecker commented 9 years ago

That would be awesome. On Mon, Jan 12, 2015 at 12:11 PM nvcexploder notifications@github.com wrote:

@geek https://github.com/geek and @kpdecker https://github.com/kpdecker : need me to check this out?

— Reply to this email directly or view it on GitHub https://github.com/walmartlabs/hula-hoop/pull/10#issuecomment-69615948.

nvcexploder commented 9 years ago

K - then I'll start taking a look very soon. :)

kpdecker commented 9 years ago

Released in 1.1.0