IT fix+add tests

[ghost]

adding tests adding some time adverbs *fixing some errors in other PR

[ghost]

I'm still getting some issues from tests, I guess I'll take some hints if possible 🙃

[ghost]

Well, I fixed some translations and tried to run the tests of which, unfortunately, some I could not get to work properly.

There are still some rather serious critical issues arose in dealing with the ambiguity of some sentences.

Eg.: There's an ambiguity in ITTimeExpressionParser.ts generated by "alle" in the followingPhase, its presence is however mandatory in both primaryPrefix and followingPhase ("dalle hh:mm alle hh:mm" means "from hh:mm to hh:mm" but using just "alle hh:mm" would mean "at hh:mm").

Moreover, as before, "all'" can be used both for literal time units and literal days of the month.

Unfortunately, ambiguities are a constant in more or less all languages and because of my knowledge of JS, I wouldn't know how to come up with it. 😕

Another problem that kept me busy was handling the digits at the beginning of the sentence as in it_time_units_ago.test.ts. I've really no clues on what's not working here.

Still needing an helping hand if possible. 🙂

Thanks, Federico

[wanasit]

Hello @federicodilo. Yes. The problem sounds difficult. I'm really sorry that I cannot really do much to help.

I think the problem is we try to support too many patterns/cases from the beginning. We should not try to make it as good as English for the first IT support. We should start recognizing a few Italian issues and add more patterns (+ tests). Then, we add more patterns and debug over time. That is how I was able to handle the complexity in other languages.

I know both you and @ntotao work very hard on translating everything, but I think it would be better for us if you could revert/re-create a smaller/minimal and easier-to-test MR.

Here are what I think we leave out for future changes:

• Not supporting the time range yet (e.g. only "alle hh:mm", not "dalle hh:mm alle hh:mm")
• Not supporting the time units yet (both ago/later)
• (If it really difficult) Not support time expression yet (only date)
• Or just set up the IT configuration with one or two extractors you are confident (+tests, of course) would be enough for the first IT support MR.

FYI. If you are participating Hacktoberfest, breaking things into multiple MRs is also better for you. If you send smaller MRs, I'll try to review and merge them as quickly as possible.