search

wangqr / Aegisub

Win64 nightly builds available at GHA artifact, also at following link:
https://ftp.wangqr.tk/aegisub/
Other
794 stars 49 forks source link

crash with vsfiltermod #92

Closed realfinder closed 3 years ago

realfinder commented 3 years ago

if the .ass file has Update Details: in [Script Info]

if the subtitles provider is vsfiltermod (default) and if you have both video and subtitle it will crash with this

image

then image

test file track3_eng.zip

Masaiki commented 3 years ago

fixed. You can find the lastest version on https://github.com/Masaiki/VSFilterMod/actions By the way, this issue should be opened on the VSFilterMod repo.

wangqr commented 3 years ago

FYI: The VsFilterMod.dll included in binary releases is from sorayuki/VSFilterMod

Masaiki commented 3 years ago

FYI: The VsFilterMod.dll included in binary releases is from sorayuki/VSFilterMod

do you have interest in changing VSFilterMod binary release to my fork's?

realfinder commented 3 years ago

@Masaiki can you make a .dll binary release? I didn't see you build one https://github.com/Masaiki/VSFilterMod/releases

Masaiki commented 3 years ago

@Masaiki can you make a .dll binary release? I didn't see you build one https://github.com/Masaiki/VSFilterMod/releases

Open the workflow runs, you will find the .dll binary release under Artifacts builded by github actions.

wangqr commented 3 years ago

do you have interest in changing VSFilterMod binary release to my fork's?

Can you create a PR at sorayuki fork to see if that repo is still maintained?

Masaiki commented 3 years ago

do you have interest in changing VSFilterMod binary release to my fork's?

Can you create a PR at sorayuki fork to see if that repo is still maintained?

My commits have been merged.

wangqr commented 3 years ago

My commits have been merged.

Thanks for the effort! Binary builds from r9185 will use r5.2.4 from sorayuki fork.