wangxiaoxiang / mobileterminal

Automatically exported from code.google.com/p/mobileterminal
0 stars 1 forks source link

Preferences are not saved #254

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago
What steps will reproduce the problem?
1. Change a preference such as a gesture action or shortcut menu item
2. Close the application
3. Open the application

What is the expected output? What do you see instead?
Expect to see changes to preferences saved, instead they remain the default.

What version of the product are you using? On what operating system?
MobileTerminal 511-1 on iOS 4.2.1

Please provide any additional information below.

Original issue reported on code.google.com by jamesmor...@gmail.com on 27 Jan 2011 at 3:20

GoogleCodeExporter commented 8 years ago
Indeed, I can verify this issue
(Shame on me, I thought i had it reported already)

Original comment by dave.sto...@gmail.com on 27 Jan 2011 at 4:18

GoogleCodeExporter commented 8 years ago
Please, please, PLEASE change the priority of making these preferences into XML 
plists to critical while fixing this issue.  "Two birds with one stone."

Original comment by paul.w.palm@gmail.com on 27 Jan 2011 at 5:37

GoogleCodeExporter commented 8 years ago
Are there any attempts getting this fixed?
It's really annoying to me that I have re-assign up and down every time I need 
to open MobileTerminal

Original comment by dave.sto...@gmail.com on 7 Feb 2011 at 4:35

GoogleCodeExporter commented 8 years ago
Definitely the highest priority bug, but I don't think anyone has had a chance 
to fix it yet.

Original comment by allen.po...@gmail.com on 7 Feb 2011 at 5:56

GoogleCodeExporter commented 8 years ago
Well, I'm mostly writing in Bash currently, but I'm very familiar with C#/Java.

I believe the preferences should be loaded from a file.
Currently, it seems as if they'd be just a variable or something which is 
re-assigned as "Unassigned" every time the App is started.

In which file is dealt with preferences so I can take a look at it?

Original comment by dave.sto...@gmail.com on 7 Feb 2011 at 6:09

GoogleCodeExporter commented 8 years ago
> In which file is dealt with preferences so I can take a look at it?

Gestures are in the file "GestureInputActions.plist" which is located within 
the /Applications/Terminal.app.  Shortcuts are stored in 
/private/var/mobile/Library/Preferences/com.googlecode.mobileterminal.Terminal.p
list but are in a hopeless
binary format.

Both should be stored in /private/var/mobile/Library/Preferences and be in the 
readily understandable and alterable XML plist format.  That format will even 
allow the order of the shortcuts menu to be set.

Of course, something went bad around r510 and now no preferences work.

Original comment by paul.w.palm@gmail.com on 7 Feb 2011 at 8:52

GoogleCodeExporter commented 8 years ago
I am still using the old MobileTerminal on my 3.1.3 iPod Touch 1G, so I 
cannot say for sure, but if the preferences are in a binary plist, surely they 
can be converted to XML using the following command… (plutil is in the 
com.ericasadun.utilities package; at least it used to be when I was installing 
my system.)

plutil -convert /var/mobile/Library/Preferences/xml1 
com.google.code.mobileterminal.Terminal.plist

Original comment by chortos@inbox.lv on 7 Feb 2011 at 11:42

GoogleCodeExporter commented 8 years ago
Oops, that was supposed to be plutil -convert xml1 
/var/mobile/Library/Preferences/com.google.code.mobileterminal.Terminal.plist

Original comment by chortos@inbox.lv on 7 Feb 2011 at 11:42

GoogleCodeExporter commented 8 years ago
This issue was closed by revision r520.

Original comment by allen.po...@gmail.com on 13 Feb 2011 at 10:26

GoogleCodeExporter commented 8 years ago
It was much easier to just fix the NSUserDefaults than to re-write the entire 
preferences system to use XML.  Sorry Paul, I just don't have a lot of spare 
time at the moment.

I will file  another bug suggesting that we change over to a preferences format 
that is editable.  I think the way to go about this is to continue using 
NSUserDefaults, but write preferences in a form that is easier to edit.  
Currently we combine NSCoder and NSUserDefaults which ends up with binary data 
written inside of NSUserDefaults which is dump.

Original comment by allen.po...@gmail.com on 13 Feb 2011 at 10:28