search

wardle / go-terminology

A SNOMED terminology server and command line tool.
Apache License 2.0
35 stars 5 forks source link

Test failure when running `make` #3

Closed inglesp closed 4 years ago

inglesp commented 4 years ago

I've followed the instructions in the README, but get an error when I run make:

$ make
protoc -Ivendor/terminology/protos --go_out=plugins=grpc:snomed vendor/terminology/protos/snomed.proto
protoc -Ivendor/terminology/protos -Ivendor/terminology/vendor/googleapis --go_out=plugins=grpc:snomed vendor/terminology/protos/server.proto
protoc -Ivendor/terminology/protos -Ivendor/terminology/vendor/googleapis --grpc-gateway_out=logtostderr=true:snomed vendor/terminology/protos/server.proto
protoc -Ivendor/terminology/protos -Ivendor/terminology/vendor/googleapis --swagger_out=logtostderr=true:. vendor/terminology/protos/server.proto
?       github.com/wardle/go-terminology    [no test files]
ok      github.com/wardle/go-terminology/dmd    0.841s  coverage: 0.0% of statements
ok      github.com/wardle/go-terminology/expression 0.883s  coverage: 20.7% of statements
?       github.com/wardle/go-terminology/expression/cg  [no test files]
?       github.com/wardle/go-terminology/expression/ecl [no test files]
ok      github.com/wardle/go-terminology/server 1.612s
ok      github.com/wardle/go-terminology/snomed 0.303s  coverage: 4.7% of statements

Processed total: 4 descriptions in 124.882984ms.
2020/03/30 21:54:44 proto: don't know how to compare []
--- FAIL: TestStore (0.36s)
    service_fake_test.go:78: Concept not stored and retrieved correctly! Tried to store: id:24700007 effective_time:<seconds:1498867200 > active:true definition_status_id:900000000000073002 , got back id:24700007 effective_time:<seconds:1498867200 > active:true definition_status_id:900000000000073002 
FAIL
coverage: 34.0% of statements
FAIL    github.com/wardle/go-terminology/terminology    1.611s
ok      github.com/wardle/go-terminology/verhoeff   0.240s  coverage: 46.2% of statements
FAIL
make: *** [test] Error 1

Here's my version of go:

$ go version
go version go1.14.1 darwin/amd64

I'm new to go, so I'm not sure what other information would be useful.

This is possibly a red herring, but when running go get -u I see:

go get: github.com/etcd-io/bbolt@v1.3.3 updating to
    github.com/etcd-io/bbolt@v1.3.4: parsing go.mod:
    module declares its path as: go.etcd.io/bbolt
            but was required as: github.com/etcd-io/bbolt
wardle commented 4 years ago

Fixed in commit f6b933ad9; I was using an old gogo/protobuf fork which didn't matter until the new golang.V2 release. Removed pretty much all traces of that fork so that test now passes. I note I've accidentally committed some early work on processing SNOMED expressions so one of those tests failed - I'll deal with that next!