warp-id / solana-trading-bot

Solana Trading Bot - Beta
Microsoft Public License
1.46k stars 679 forks source link

Some feedback, some questions #20

Closed mikesens closed 5 months ago

mikesens commented 8 months ago

Not pro coder feedback

Just wanted to drop some feedback. This code I've been testing from open sources is rock solid, delivering the best results I've seen yet (pool detection speed). The author is pure gold. I've put it through its paces with various public nodes and geos (like Helius, which spans multiple regions/countries, though exact city details are scarce).

Observations:

Would be awesome if @fdundjer or other contributors would prompt how to build 'sell-after' function

p.s. If someone is looking to integrate basic pool/token info to filter out scam pools (liquidity, authority, Raydium supply, top holders, and socials), below are my findings as far:

1) Liquidity amount: QuoteVault is probably where its stored. getBalance method can be used to obtain LP in Sol. 2) Supply/Top holders%/Raydiyum%: raw data can be obtained using getTokenSupply / getTokenLargestAccounts / getParsedAccountInfo 3) Mint/Freeze authority authority, deployer info can be decoded from account data: https://www.helius.dev/blog/solana-dev-101-deserializing-account-data-on-solana

BR

fdundjer commented 8 months ago

@mikesens Thanks for kind words. Playing around with commitment level increases detection speed, but some transactions may not succeed. I set a default value to finalized to lower the amount of reported issues for failed transactions. Got a few of them reported on Discord :(

Regarding new features, it's a tradeoff between performance and functionality. My initial intention with the script was to be performant. Adding new features will affect that performance. I'll have to think about how to include that.

The sell function is in backlog, I'll add it when I have free time.

b-Snaas commented 8 months ago

@mikesens

I totally agree with your findings. Did you manage to get any further with creating a filter?

fdundjer commented 5 months ago

Added new filters in v2. Closing the issue for now