warpdotdev / Warp

Warp is a modern, Rust-based terminal with AI built in so you and your team can build great software, faster.
https://warp.dev
Other
20.85k stars 355 forks source link

Keybindings don't trigger on non-US input sources - international i18n ime international keyboards #341

Open chevsky opened 2 years ago

chevsky commented 2 years ago

Describe the bug

Seems like keybindings rely on current input source.
For example, `cmd+p` does nothing while Ukrainian input source selected, same for `ctrl+r`. Same for `cmd+,` on French input source, etc.

To Reproduce

Steps to reproduce:

  1. Select non-US input source, ideally Cyrillic (e.g. Ukrainian)
  2. Press cmd+p

Expected behaviour

Command Palette should open.

Screenshots

No response

Operating System

MacOS

OS Version

12.0.1

Additional context

No response

kevinyang372 commented 2 years ago

Thanks for reporting! This issue is caused by us how we interpret key presses (see here for an explanation of these concepts). There are tradeoffs to all three methods and ideally we should provide a setting for user to choose which one to use.

elviskahoro commented 2 years ago

From @sunyouman via #678

Describe the bug

I use Korean Language.
When keyboard setting is Korean, I does not work Shortcut.

To Reproduce

Steps to reproduce:

  1. Change keyboard language to Korean
  2. Cmd + E
  3. Not working

However, Default Shortcut is OK (like Cmd + W)

Expected behaviour

Shortcut is worked

Screenshots

No response

Operating System

MacOS

OS Version

11.6

Additional context

No response

yam-liu commented 2 years ago

Any update on this issue? it didn't work after 2022.04.18 version.

l3ve commented 2 years ago

any news? same problem on Chinese. and now, i have to switch input to ABC, then can be open

yam-liu commented 2 years ago

any news? same problem on Chinese. and now, i have to switch input to ABC, then can be open

You can use macism and skhd to solve this bug temporarily.

For me: (f18 is the switch of en/zh input method, macism can also do this)

# fix Warp Chinese input method hotkey window issue
alt - space : [[ "$(macism)" = 'com.apple.keylayout.ABC' ]] && (skhd -k 'f2') || (skhd -k 'f18' && skhd -k 'f2')
tkafka commented 2 years ago

Probable duplicates: #1423, #1302, #1413, #1309

elviskahoro commented 2 years ago

@tkafka thanks for the help! Will reach out and circle back when there are updates.

supervate commented 2 years ago

any news? same problem on Chinese. and now, i have to switch input to ABC, then can be open

You can use macism and skhd to solve this bug temporarily.

For me: (f18 is the switch of en/zh input method, macism can also do this)

# fix Warp Chinese input method hotkey window issue
alt - space : [[ "$(macism)" = 'com.apple.keylayout.ABC' ]] && (skhd -k 'f2') || (skhd -k 'f18' && skhd -k 'f2')

你这个意思是先切换成苹果默认的输入法再去按hotkey吗...

yam-liu commented 2 years ago

@suopovate 是的

supervate commented 2 years ago

这个hotKey的体验太糟糕了,除了输入法会导致hotKey失效,即使输入法没问题,也会在更新系统或者某些情况下,失效。。。重新给 warp 授权也无用

andremacola commented 1 year ago

Using International US layout for portuguese does not work either.

h3z commented 1 year ago

Thanks for reporting! This issue is caused by us how we interpret key presses (see here for an explanation of these concepts). There are tradeoffs to all three methods and ideally we should provide a setting for user to choose which one to use.

Really need the opportunity to choose. I can't use warp 100% because this issue. Shortcut is very important as a tool.

anfomin commented 1 year ago

Any updates on this issue? It is very annoying to switch to ABC every time to open hotkey window when working on multi-layout keyboard 🤯

neoantox commented 1 year ago

Any updates on this issue? This bug is the only reason why I can't switch to Warp. Could you at least give us an option to set multiple hotkeys for different layouts?

dannyneira commented 1 year ago

Quick update, we're working on IME (input method editor, aka international keyboard ) support. I believe CJK support is up first, with others to follow in the future.

Bringoff commented 1 year ago

For example, cmd+p does nothing while Ukrainian input source selected

Interestingly enough, this one works for me in the latest version. But when I set up a global shortcut for the hotkey window (Opt+Cmd+T), it does only work with the English input source being active.

h3z commented 1 year ago

any news? same problem on Chinese. and now, i have to switch input to ABC, then can be open

You can use macism and skhd to solve this bug temporarily.

For me: (f18 is the switch of en/zh input method, macism can also do this)

# fix Warp Chinese input method hotkey window issue
alt - space : [[ "$(macism)" = 'com.apple.keylayout.ABC' ]] && (skhd -k 'f2') || (skhd -k 'f18' && skhd -k 'f2')

体验完美, 感谢分享

dannyneira commented 1 year ago

Discord comment:

AZERTY keyboard layout also has issues with keyboard shortcuts

chevsky commented 1 year ago

Closing this one as the initial issue was fixed. Keybindings work well using different input sources. Version: v0.2023.06.27.19.34.stable_01

q344144460 commented 1 year ago

not work version: v0.2023.06.27.19.34.stable_01

totally same https://github.com/warpdotdev/Warp/issues/2226#issuecomment-1326925705

yam-liu commented 1 year ago

+1

YanHuize @.***>于2023年7月3日 周一22:14写道:

not work version: v0.2023.06.27.19.34.stable_01

totally same

2226 (comment)

https://github.com/warpdotdev/Warp/issues/2226#issuecomment-1326925705

— Reply to this email directly, view it on GitHub https://github.com/warpdotdev/Warp/issues/341#issuecomment-1618398332, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAICAI2HNSWL7LYEUP2AMJTXOLHVRANCNFSM5HFCH7PA . You are receiving this because you commented.Message ID: @.***>

supervate commented 1 year ago

+1

Fenhy commented 1 year ago

Still not working in v0.2023.06.27.19.34 stable_01

not work version: v0.2023.06.27.19.34.stable_01

totally same #2226 (comment)

dannyneira commented 1 year ago

Reopening as users still appear to have this issue.

As a possible workaround, try and switch the input to ABC ( US ) keyboard or a more involved workaround is to rebind the keyboard shortcuts while you're input is international and try again.

Longer term we're aware of the issue and it's on the backlog of things we can improve in the future so we appreciate your patience with this issue and it's complicated to fix.

adildg commented 11 months ago

+1

version: _v0.2023.09.06.18.09.stable00 OS: Ventura 13.4 I am using a Belgian keyboard layout and it doesn't work. I have also tried with the French layout, still the same problem.

97Yates05 commented 9 months ago

离谱,两年多了,还没修复。。如果这是个很复杂的问题,那 iterm是如何解决的呢?

97Yates05 commented 9 months ago

This is ridiculous, it's been over two years and it still hasn't been fixed... If this is a really complicated issue, then how did iterm2 solve it?

yangchuansheng commented 8 months ago

This is ridiculous, it's been over two years and it still hasn't been fixed... If this is a really complicated issue, then how did iterm2 solve it?

+1

97Yates05 commented 6 months ago

@dannyneira If this app is intended only for native English speakers, please indicate this prominently. Leaving an issue unfixed for three years can appear incompetent, especially since this problem does not exist in similar products.No offense intended, just stating the facts.

yooakim commented 6 months ago

Same issue as already reported above, key cominatiosn do not work when using SWEDISH keyboard. On Ubuntu 23.10

yam-liu commented 4 months ago

2 years and a half, super disappointed.

supervate commented 4 months ago

I've accepted this result that you can't get it done.

Bringoff commented 4 months ago

This and forced sign-in made me switch back to iTerm2

anson0370 commented 4 months ago

Many times I've tried switching to Warp, but each time I switched back to iTerm2 because of this issue. Once, I thought about fixing the problem myself, then realized that Warp is not open source.

alfred-zhong commented 4 months ago

Many times I've tried switching to Warp, but each time I switched back to iTerm2 because of this issue. Once, I thought about fixing the problem myself, then realized that Warp is not open source.

Me, too. It's the only issue which stops me from using warp.

evolify commented 4 months ago

Come back to check this issue every months, but still not fixed for years...☹️

supervate commented 4 months ago

Come back to check this issue every months, but still not fixed for years...☹️

You are so humorous.

igomonteiro commented 2 months ago

Same problem here, related on https://github.com/warpdotdev/Warp/issues/4975

ChihGodlee commented 2 months ago

The official just put a bug label on it and left it here for everyone to enjoy?

supervate commented 2 months ago

The official just put a bug label on it and left it here for everyone to enjoy?

Maybe its not a important problem for official, or they just don't care, or they can't resolve it because of the dependent components don't fix their bugs.

I don't know, but as you can see, they didn't resolve this problem for three years.

xwatsonmai commented 2 months ago

I originally thought I could find a solution here, but I was wrong. There is only despair here.

yangchuansheng commented 1 month ago

Come back to check this issue every months, but still not fixed for years...☹️

RuiFG commented 1 month ago

Let's vote by uninstall