warren-bank / node-hls-downloader-tubitv

Command-line utility for downloading an offline copy of TubiTV HLS video streams.
GNU General Public License v2.0
58 stars 8 forks source link

--help doesn't seem to work #7

Closed ileGITimo closed 1 year ago

ileGITimo commented 1 year ago

% tubidl --help /usr/local/lib/node_modules/@warren-bank/node-hls-downloader-tubitv/bin/tubitv-downloader/help.js:38 1 = "${movie-or-episode-title}.mp4" ^

ReferenceError: movie is not defined at Object. (/usr/local/lib/node_modules/@warren-bank/node-hls-downloader-tubitv/bin/tubitv-downloader/help.js:38:14) at Module._compile (node:internal/modules/cjs/loader:1254:14) at Module._extensions..js (node:internal/modules/cjs/loader:1308:10) at Module.load (node:internal/modules/cjs/loader:1117:32) at Module._load (node:internal/modules/cjs/loader:958:12) at Module.require (node:internal/modules/cjs/loader:1141:19) at require (node:internal/modules/cjs/helpers:110:18) at Object. (/usr/local/lib/node_modules/@warren-bank/node-hls-downloader-tubitv/bin/tubitv-downloader/process_argv.js:45:16) at Module._compile (node:internal/modules/cjs/loader:1254:14) at Module._extensions..js (node:internal/modules/cjs/loader:1308:10)

warren-bank commented 1 year ago

thanks for catching that.. it was a dumb bug.. introduced in v1.5.0.. fixed in v1.5.1 by this commit.

ileGITimo commented 1 year ago

Thanks for fixing it. I was checking your method as a way to get subtitles, if I ever need them. I usually just get the m3u8 url with Firefox dev mode. then feed it to ffmpeg.