Dialog: [OK] button is confusing on some dialogs

wasabee-project / Wasabee-IITC

ENL DrawTools and Op Management

Apache License 2.0

30 stars 21 forks source link

Dialog: [OK] button is confusing on some dialogs #323

Closed le-jeu closed 2 years ago

le-jeu commented 2 years ago

Most dialogs have a [OK] button that either confirms a user input, or just closes the dialog. This can be confusing for the user.

We first need to identify all confusing dialogs, taking account that some dialogs with user input don't wait for [OK] to use/apply the user input.

Solution can be:

Renaming [OK] to [Close] when there is nothing to confirm
Remove the [OK] button, the cross in the title bar already close the dialog
...

cloudkucooland commented 2 years ago

I think removing the [OK] button and leaving the [x] would be lest confusing to most users.

Does the new dialog framework make this easier than it used to be? These jQueryUI dialog buttons are annoying to code.

le-jeu commented 2 years ago

OK == Close

Team list
New Op
WD Keys
Checklist
Blockers
Keys list
Export
AutoDraw (list)
Add marker
Marker list
Link list
Op permissions

Update on change but OK is nice as UX

Assign
Set Comment
Set state
Settings
Skins
Op settings
Zones (confusing here)

is this complete ?

le-jeu commented 2 years ago

close by https://github.com/wasabee-project/Wasabee-IITC/commit/fc8663b4efd3445d738c0157ea2cb4267d9a87be