watson-developer-cloud / node-sdk

:comet: Node.js library to access IBM Watson services.
https://www.npmjs.com/package/ibm-watson
Apache License 2.0
1.48k stars 669 forks source link

fix(stt): timestamps type to properly reflect response model #1112

Closed paulchiu closed 3 years ago

paulchiu commented 3 years ago

Commit https://github.com/watson-developer-cloud/node-sdk/commit/84bb18da2a4431c4f59cd95f0e05c8d61cd7ab85 rolled back PR https://github.com/watson-developer-cloud/node-sdk/pull/1085, I believe this was unintentional.

I have verified that the response type is still [string, number, number], which reflects the current TSDoc too.

This change re-applies the fix created by @apaparazzi0329.

CLAassistant commented 3 years ago

CLA assistant check
All committers have signed the CLA.

apaparazzi0329 commented 3 years ago

Yes you are correct this was an unintentional change. Thank you for catching this and opening up a PR. We will look to merge your PR and release a patch for this on Monday

watson-github-bot commented 3 years ago

:tada: This PR is included in version 6.2.1 :tada:

The release is available on:

Your semantic-release bot :package::rocket: