search

watson / mongodown

A drop-in replacement for LevelDOWN that runs on MongoDB
MIT License
28 stars 16 forks source link

howdy: tests passing, passing options? #2

Closed bewest closed 9 years ago

bewest commented 9 years ago

Howdy,

I have a situation where I already have a mongo connection db and collection instances, and would like to try out mongodown as a way to introduce the code to the levelup ecosystem.

I added a few lines to attempt re-using {conn: <mongojs.connect( )>, collection: 'mycollection'} as options, but got snagged when I couldn't get tests to pass before or after my changes. Any advice? Should I comment out some tests?

bewest commented 9 years ago

Here's the patch I was experimenting with: https://github.com/watson/mongodown/pull/3

watson commented 9 years ago

Sorry about the current state of the tests. I've been waiting on a new release of the test suite which is inherited from rvagg/abstract-leveldown which will allow me to debug why Travis-CI fails even though the tests run fine locally. But maybe I should just hardcode the git rev in package.json for the time being...

watson commented 9 years ago

But thanks for the pull request. I'll check it out and get back :)

watson commented 9 years ago

This one slipped through the cracks sorry... The issue seems to be related to MongoDB. The tests parse fine on v2.6, but fails on v2.4 (which is the version running on Travis-CI). I'll make a fix

watson commented 9 years ago

@bewest I finally managed to track down and fix this bug. It turned out that the module didn't work in MongoDB 2.4.x (so the tests broke if running on that version of Mongo of cause). It has now been fixed in 5390914 and released as v1.0.2 on NPM.

I've also setup a Travis-CI build matrix now so that I always test against the different versions of MongoDB (currently 2.4, 2.6 and 2.8)

bewest commented 9 years ago

Awesome!! :+1: