New and motivated project member

toelke commented 4 months ago

Hey all!

This is not an issue, but me reaching out to the rest of the project (such as it is). @wonderhoss was nice enough to add me to the project after I voiced my wish to contribute.

I am not here to step on anyone's toes, but I am motivated to push this project forward.

This is my preliminary plan:

merge a number of auto-closed PRs (RBAC, k8s version, some small features) :heavy_check_mark:
migrate from dep to go mod (https://www.cockroachlabs.com/blog/dep-go-modules/) :heavy_check_mark:
update all dependencies
disable the autoclose-on-stale :heavy_check_mark: (https://github.com/wave-k8s/wave/pull/140) and re-open all issues+PRs closed by it (https://drewdevault.com/2021/10/26/stalebot.html) – as long as they still seem relevant after the previous steps; label open Issues with FeatureRequest, Bug, … :heavy_check_mark:
Set up some forum for discussing things, e.g. GitHub discussions
Add some tests, especially end-to-end tests with different Kubernetes versions (https://github.com/wave-k8s/wave/pull/139) :heavy_check_mark:

I will start doing these things in the upcoming weeks if nobody complains first 😃 (see stepping on toes).

Cheers, Philipp

jan-kantert commented 4 months ago

Appreciate it! We would be migrating off otherwise since current version does not play well with recent kubernetes versions anymore.

mamccorm commented 3 months ago

Hey @toelke - we're 'attempting' to do the migration from 'dep' to go.mod. This is our work so far:

https://github.com/wave-k8s/wave/compare/master...mamccorm:wave:master

Full disclosure - i'm not a go developer so largely trial and error and piecing bits together. api and webhook build fine, but controller and core do not (yet).

toelke commented 3 months ago

Hey.

There is also https://github.com/wave-k8s/wave/pull/105 and https://github.com/wave-k8s/wave/pull/107.

I tested #107. The build works and creates a working binary. The tests fail, however, as the Makefile does a lot of go install / go get where the sematics have changed or the old versions are no longer available (I found that for go generate, for example).

mamccorm commented 3 months ago

Thanks @toelke, dropped a comment over in https://github.com/wave-k8s/wave/pull/107 with a possible suggestion to fix the failing CI tests.

toelke commented 3 months ago

Sorry, yes. It's in my queue. Expect a reaction until the weekend.

mamccorm commented 2 months ago

Hey @toelke, how's the above going? Does it look any closer? :)

toelke commented 2 months ago

I replied here: https://github.com/starkers/wave/pull/1#issuecomment-2025929876

toelke commented 1 week ago

I'll close this, as initial communication is done.

wave-k8s / wave

New and motivated project member #138