search

wave-k8s / wave

Kubernetes configuration tracking controller
Apache License 2.0
646 stars 82 forks source link

Upgrade to 4.1 fails #166

Closed jabdoa2 closed 1 month ago

jabdoa2 commented 1 month ago

Upgrade from 4.0 to 4.1 fails:

wave   283d   False   Helm upgrade failed for release wave/wave with chart wave@4.1.0: cannot patch "wave-wave" with kind Deployment: Deployment.extensions "wave-wave" is invalid: spec.selector: Invalid value: v1.LabelSelector{MatchLabels:map[string]string{"app":"wave", "heritage":"Helm", "release":"wave"}, MatchExpressions:[]v1.LabelSelectorRequirement(nil)}: field is immutable

Deleting the helm release fixes it.

toelke commented 1 month ago

Fixed with #159, I think.

jabdoa2 commented 1 month ago

Previous upgrades worked fine. I guess it was caused be the removal of that annotation. Since wave does not have any state its ok to delete and recreate the release.

Perf-wise the upgrade looks good: up to 21:00 - 0.5 21:00 - 0.7 10:00 - 0.8

grafik grafik

This is 1k deployments, 2k configmaps and 6k secrets. So perf-wise it looks very good.

toelke commented 1 month ago

I saw that error for the previous updates as well.

jabdoa2 commented 1 month ago

We will roll out the next stage of clusters next week. I guess it will happen everywhere but it should be good after that.