Promote fs-extra, onml, and yargs to dependencies

wavedrom / bitfield

:cake: bit field diagram renderer

MIT License

340 stars 26 forks source link

Promote fs-extra, onml, and yargs to dependencies #15

Closed mx-shift closed 6 years ago

mx-shift commented 6 years ago

In a clean NPM environemnt, npm i bit-field yields a bitfield that fails to run. fs-extra, onml, and yargs are required for execution but are listed only as devDepdencies. Promoting them to dependencies ensures they are installed when bit-field is installed.

Signed-off-by: Rick Altherr kc8apf@kc8apf.net

drom commented 6 years ago

Yes, you are right. It is broken this way. How about I include browserify step and distribute bundled version of bin/bitfield.js ?

mx-shift commented 6 years ago

Personally I prefer to use NPM. Even if you choose to primarily distribute a bundled version, having the NPM dependencies work properly is important for anyone wanting to use it in their own project.

drom commented 6 years ago

Sounds fine to me!

drom commented 6 years ago

Just published v0.6.0