search

waynebhayes / SANA

Simulating Annealing Network Aligner
25 stars 39 forks source link

[WIP] Handle self-loops(needs to be tested) #61

Closed idetatsu closed 5 years ago

idetatsu commented 5 years ago

I am still running the regression test to make sure there is no unwanted changes, but here's the code that we discussed last week.

It allows both graphs g1 and g2 to have self-loops and (hopefully) is able to align them as well. We'll be able to test if that's the case by the test suite that I am working on right now.

waynebhayes commented 5 years ago

Ok cool

Sent from my iPhone

On Feb 1, 2019, at 10:41, Tatsuro Ide notifications@github.com wrote:

I am still running the regression test to make sure there is no unwanted changes, but here's the code that we discussed last week.

It allows both graphs g1 and g2 to have self-loops and (hopefully) is able to align them as well. We'll be able to test if that's the case by the test suite that I am working on right now.

You can view, comment on, or merge this pull request online at:

https://github.com/waynebhayes/SANA/pull/61

Commit Summary

Handle self-loops(needs to be tested) File Changes

M src/Graph.cpp (38) M src/Graph.hpp (2) M src/methods/SANA.cpp (39) Patch Links:

https://github.com/waynebhayes/SANA/pull/61.patch https://github.com/waynebhayes/SANA/pull/61.diff — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or mute the thread.

waynebhayes commented 5 years ago

Any more news on this?

waynebhayes commented 5 years ago

It's been almost a month. Can we get this in soon? I also haven't seen you in meetings for awhile. If you want to continue in the group, get this done this week.

-- Wayne Hayes, Ph.D. Associate Professor of Computer Science, University of California, Irvine Director, UCI-SDSU Joint Ph.D. Program in Computational Science (UCI side) The evidence is now incontrovertible that Russia interfered with the 2016 US Presidential election by manipulating public opinion with disinformation via thousands of fake social media accounts. Why? Follow the money: Trump has been laundering it for Russian billionaires, including Putin, for 20 years. Details and fact checking at https://secure.avaaz.org/campaign/en/shocking_truth_about_trump/?bebhylb https://secure.avaaz.org/campaign/en/shocking_truth_about_trump/?bebhylb. The opinions expressed in this email by Professor Hayes are his and his alone, and are not meant to represent those of the University of California.

On Sat, Feb 2, 2019 at 6:01 PM Wayne Hayes whayes@uci.edu wrote:

Ok cool

Sent from my iPhone

On Feb 1, 2019, at 10:41, Tatsuro Ide notifications@github.com wrote:

I am still running the regression test to make sure there is no unwanted changes, but here's the code that we discussed last week.

It allows both graphs g1 and g2 to have self-loops and (hopefully) is able to align them as well. We'll be able to test if that's the case by the test suite that I am working on right now.

You can view, comment on, or merge this pull request online at:

https://github.com/waynebhayes/SANA/pull/61 Commit Summary

  • Handle self-loops(needs to be tested)

File Changes

Patch Links:

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/waynebhayes/SANA/pull/61, or mute the thread https://github.com/notifications/unsubscribe-auth/ATUkjDen86nF8oKKHPrEBsmxJJMGEVIpks5vJIpAgaJpZM4ae3WJ .

idetatsu commented 5 years ago

@waynebhayes I'm sorry I took so long to finish this. I have made changes regarding what you mentioned earlier. Please check it out.