waynebhayes / SANA

Simulating Annealing Network Aligner
25 stars 39 forks source link

Graph Switching fix #72

Closed nshah9856 closed 5 years ago

nshah9856 commented 5 years ago

As an example, if we align RNorvegicus and SPombe, RN is smaller than SP. The sequence file SANA looks for is sequence/scores/RNorvegicus-SPombe.blast_out. However, if the user listed - g1 as SP and -g2 as RN, then the sequence code will look for sequence/scores/SPombe- RNorvegicus.blast_out, but that file doesn't exist, because the files are named [small]- [large].blast_out. The fix takes care of this by using the _graphSwitched Boolean condition to check if the graphs are switched or not and take care of the problem accordingly.

This is a draft PR, because the fix has not been tested yet. We are unable to recreate the issue and are waiting for fellow student to send us the specific command line arguments.

nshah9856 commented 5 years ago

Made the appropriate changes. Also, once we switch to using C++ 20 standard, we can simple use ".contains" method instead of the long ".find" making it more readable