waynebhayes / SANA

Simulating Annealing Network Aligner
25 stars 39 forks source link

Renamed -nodes-have-types and associated vars/functions to bipartite, fixed issue where SANA created folders for every network it saw #91

Closed rasulsafa closed 5 years ago

rasulsafa commented 5 years ago

In this pull request, the option -nodes-have-types was renamed to -bipartite. However, this mode seemed to have been disabled for some reason and only was only enabled for graphs loaded from binary files. image This code snippet that includes g.nodesHaveTypesEnabled = nodesHaveTypes; in Graph.cpp is not present in any of the other graph file loading functions, thus any attempts to run SANA in this mode resulted in a segfault. I fixed this by moving this line into loadGraphFromPath, which calls each of the specialized graph loading functions.

In this pull request I also made SANA stop creating a folder in networks/ for every new network. The code doing this appeared to be part of something unfinished related to caching.