search

wazuh / wazuh-packages

Wazuh - Tools for packages creation
https://wazuh.com
GNU General Public License v2.0
105 stars 98 forks source link

SPECS for new SCA Windows Server 2012 (non R2) #3073

Closed jk-olaoluwa closed 2 months ago

jk-olaoluwa commented 3 months ago

Create SPECS as needed for a new OS SCA

PR - https://github.com/wazuh/wazuh/pull/21794 Is ready to merge Branch - https://github.com/wazuh/wazuh/tree/18535-create-sca-policy-for-windows-server-2012-non-r2

PLEASE confirm with @wazuh/threat-intel before merging.

lchico commented 3 months ago

Hello @jk-olaoluwa, For windows, we don't need to change the SPCEC, just add it to wazuh/src/win32/wazuh-installer.wxs, so you can do it on the same PR that you work on. Here you will have an example: https://github.com/wazuh/wazuh/pull/13899 Please let me know if you need any help with that.

jk-olaoluwa commented 3 months ago

Hello @jk-olaoluwa, For windows, we don't need to change the SPCEC, just add it to wazuh/src/win32/wazuh-installer.wxs, so you can do it on the same PR that you work on. Here you will have an example: wazuh/wazuh#13899 Please let me know if you need any help with that.

The wazuh/src/win32/wazuh-installer.wxs file has been updated here - https://github.com/wazuh/wazuh/commit/e5d2e5681ccd7a17d9bfc2ad948c080126c6dcc1

lchico commented 3 months ago

Update

I followed up with @jk-olaoluwa; this was already solved, as he mentioned in this commit https://github.com/wazuh/wazuh/commit/e5d2e5681ccd7a17d9bfc2ad948c080126c6dcc1.

MarcelKemp commented 2 months ago

The changes that have been merged do not work correctly, as the following line is missing:

            <ComponentRef Id="SCA_WIN2012NONR2" />

This is causing failures in the checks and msi generation:

jk-olaoluwa commented 2 months ago

The changes that have been merged do not work correctly, as the following line is missing:

            <ComponentRef Id="SCA_WIN2012NONR2" />

This is causing failures in the checks and msi generation:

Hello @MarcelKemp, this has been resolved here - https://github.com/wazuh/wazuh/commit/f1bc6f0b8dde0038f34ebb86bbed0ecbaad372b5

MarcelKemp commented 2 months ago

Hi @jk-olaoluwa, As soon as you merge the commit, let us know, and we will check that everything works correctly, so we can close the issue.

Thanks in advance!

jk-olaoluwa commented 2 months ago

Hi @jk-olaoluwa, As soon as you merge the commit, let us know, and we will check that everything works correctly, so we can close the issue.

Thanks in advance!

Commit has been merged - https://github.com/wazuh/wazuh-packages/issues/3073#issuecomment-2312183590

MarcelKemp commented 2 months ago

As I see that the job is now working correctly, I am closing the issue as completed: