wbrawner / SimpleMarkdown

SimpleMarkdown is an Android app for editing Markdown!
https://play.google.com/store/apps/details?id=com.wbrawner.simplemarkdown
Apache License 2.0
158 stars 18 forks source link

Crashing while opening File Save menu #32

Closed kartikay-bagla closed 6 years ago

kartikay-bagla commented 6 years ago

I'm using a 10.or G phone with Android 7.1.2. While attempting to save a md file, the app crashed (and took all my work away with it :'-( ). Lemme know what more details you need to solve this. I was really liking the minimalist approach and design of the app!

wbrawner commented 6 years ago

Hey, I'm terribly sorry about the crash and my delay in getting back to you! I'm not getting emails for issues for some reason so I'll have to look into that.

As for the info, are you able to consistently reproduce the crash or is it more random? And do you have an SD card in your device or just the built-in storage?

kartikay-bagla commented 6 years ago

The issue is more random, I think it might have something to do with the size of the file being saved. It mostly happened when I wrote long files (700+ characters). And I only have built-in storage.

On Mon 20 Aug, 2018, 19:28 Billy Brawner, notifications@github.com wrote:

Hey, I'm terribly sorry about the crash and my delay in getting back to you! I'm not getting emails for issues for some reason so I'll have to look into that.

As for the info, are you able to consistently reproduce the crash or is it more random? And do you have an SD card in your device or just the built-in storage?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/wbrawner/SimpleMarkdown/issues/32#issuecomment-414325454, or mute the thread https://github.com/notifications/unsubscribe-auth/ASfKSuPc_phqp8OhGl1FQEYEZsuTqbT9ks5uSsBtgaJpZM4V5LZa .

wbrawner commented 6 years ago

Ok, that's pretty helpful info, thanks. I'll see if I can reproduce the issue and find out what's going on.

wbrawner commented 6 years ago

So, I'm having a tough time reproducing this issue on my devices. If I send you a development build, would you be willing to try to provoke a crash and email me the automatically attached log info?

kartikay-bagla commented 6 years ago

Sure.

On Tue 21 Aug, 2018, 06:21 Billy Brawner, notifications@github.com wrote:

So, I'm having a tough time reproducing this issue on my devices. If I send you a development build, would you be willing to try to provoke a crash and email me the automatically attached log info?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/wbrawner/SimpleMarkdown/issues/32#issuecomment-414512716, or mute the thread https://github.com/notifications/unsubscribe-auth/ASfKSkODALz7ZFYU1POIDdYtRu6Xp9Poks5uS1mLgaJpZM4V5LZa .

wbrawner commented 6 years ago

Hey, here's a quick build for you. You won't actually have to do anything to report the crash, as I've found a better way of implementing the crash reporting automatically so if anything happens, I should see it.

https://github.com/wbrawner/SimpleMarkdown/releases/tag/acra-testing

kartikay-bagla commented 6 years ago

I'm a bit busy this weekend, so I'll be using the Dev build from Monday, I'll let you know about any future crashes. Thanks!

On Wed 22 Aug, 2018, 05:13 Billy Brawner, notifications@github.com wrote:

Hey, here's a quick build for you. You won't actually have to do anything to report the crash, as I've found a better way of implementing the crash reporting automatically so if anything happens, I should see it.

https://github.com/wbrawner/SimpleMarkdown/releases/tag/acra-testing

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/wbrawner/SimpleMarkdown/issues/32#issuecomment-414857174, or mute the thread https://github.com/notifications/unsubscribe-auth/ASfKSkozHZCshwXagkGXEBCzol5BpKKgks5uTJsMgaJpZM4V5LZa .

wbrawner commented 6 years ago

No worries, I appreciate the assistance with tracking down the bug. Thank you!

kartikay-bagla commented 6 years ago

So I wrote stuff with the app for the last 2 days and somehow I'm not able to reproduce the crash anymore. I've been using the original app from the playstore (totally forgot to install the test build). So, I'll switch to the testing version of the app today and let you know if I manage to crash the app again.

kartikay-bagla commented 6 years ago

When I try to create a new file, I get an error saying "an error occurred while saving the file". I'm using the build you sent me.

wbrawner commented 6 years ago

Hey, glad you're not getting the crash anymore :) I'm not seeing any bug reports in my dashboard, so I'll have to revisit the error reporting setup I implemented. Currently it'll only report issues to me if the app crashes, but if things keep moving along then it should still function. If you're unable to create any new files and save them, please let me know, otherwise I'll just make sure the next Play Store release has the error reporting for all errors and not just crashes.

kartikay-bagla commented 6 years ago

I can save the file, but I can't create a new file. For that I have to restart the app.

On Thu 30 Aug, 2018, 00:40 Billy Brawner, notifications@github.com wrote:

Hey, glad you're not getting the crash anymore :) I'm not seeing any bug reports in my dashboard, so I'll have to revisit the error reporting setup I implemented. Currently it'll only report issues to me if the app crashes, but if things keep moving along then it should still function. If you're unable to create any new files and save them, please let me know, otherwise I'll just make sure the next Play Store release has the error reporting for all errors and not just crashes.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/wbrawner/SimpleMarkdown/issues/32#issuecomment-417070662, or mute the thread https://github.com/notifications/unsubscribe-auth/ASfKSu2utkFl7lpcuz_swpB-S1qg5gnXks5uVucogaJpZM4V5LZa .

wbrawner commented 6 years ago

Hmm yeah that's certainly not ideal. I'll get you another build with more error reporting this weekend so we can get to the bottom of this

wbrawner commented 6 years ago

Hey @kartikay-bagla, I scrapped together a quick release for you with improved error reporting. This should give me more details about what's going on with the errors. You can grab the APK from here: https://github.com/wbrawner/SimpleMarkdown/releases/tag/v0.4.5

kartikay-bagla commented 6 years ago

I successfully replicated the error in the APK you sent. Did you recieve anything?

On Fri 31 Aug, 2018, 19:12 Billy Brawner, notifications@github.com wrote:

Hey @kartikay-bagla https://github.com/kartikay-bagla, I scrapped together a quick release for you with improved error reporting. This should give me more details about what's going on with the errors. You can grab the APK from here: https://github.com/wbrawner/SimpleMarkdown/releases/tag/v0.4.5

— You are receiving this because you were mentioned.

Reply to this email directly, view it on GitHub https://github.com/wbrawner/SimpleMarkdown/issues/32#issuecomment-417668126, or mute the thread https://github.com/notifications/unsubscribe-auth/ASfKSsgR7qWAgs8_QwZGKvO6MEPJAOfjks5uWT1OgaJpZM4V5LZa .

wbrawner commented 6 years ago

I did indeed! I'll have a look at this and let you know if I need any more information from you. Thanks for your help and patience with this!

kartikay-bagla commented 6 years ago

No problem.

On Fri 31 Aug, 2018, 19:43 Billy Brawner, notifications@github.com wrote:

I did indeed! I'll have a look at this and let you know if I need any more information from you. Thanks for your help and patience with this!

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/wbrawner/SimpleMarkdown/issues/32#issuecomment-417677037, or mute the thread https://github.com/notifications/unsubscribe-auth/ASfKSggyCjjOZkeMjzOmOd3DsYIiJp0qks5uWURtgaJpZM4V5LZa .

wbrawner commented 6 years ago

Hey @kartikay-bagla, I think I've resolved the issue, but I'm not 100% certain. I see you've run into it a few more times so I'm hoping that with the latest build it's fixed. I'll post a link here shortly.

wbrawner commented 6 years ago

Here's the link for you: https://github.com/wbrawner/SimpleMarkdown/releases/tag/v0.4.6

kartikay-bagla commented 6 years ago

Yes, sometimes I forget the bug and accidentally and up creating a new file. I'll test this build, and let you know if anything comes up. Thanks a lot!

On Wed 5 Sep, 2018, 05:36 Billy Brawner, notifications@github.com wrote:

Here's the link for you: https://github.com/wbrawner/SimpleMarkdown/releases/tag/v0.4.6

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/wbrawner/SimpleMarkdown/issues/32#issuecomment-418556461, or mute the thread https://github.com/notifications/unsubscribe-auth/ASfKSluH6shQNutInKDIRYM-WX2F1t5kks5uXxWPgaJpZM4V5LZa .

wbrawner commented 6 years ago

Great, fingers crossed it's working for you now! 🤞 Thank you for the assistance in debugging this!

kartikay-bagla commented 6 years ago

It's working now! This is more of a feature request, so when I select New File, it just saves file with the name (default is Untitled) and opens another one, there should be an option to discard, choose the file name and save.

On Wed 5 Sep, 2018, 18:39 Billy Brawner, notifications@github.com wrote:

Great, fingers crossed it's working for you now! 🤞 Thank you for the assistance in debugging this!

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/wbrawner/SimpleMarkdown/issues/32#issuecomment-418724335, or mute the thread https://github.com/notifications/unsubscribe-auth/ASfKSuH2RYJdpvEgmj8ECL1BHGrNvMo1ks5uX80QgaJpZM4V5LZa .

wbrawner commented 6 years ago

Awesome! I'm glad it's working for you now :) I'll do a few more clean up tasks and publish to the Play Store this weekend then with an updated version so you should be able to continue getting updates through there.

Thanks for the feature request! I've moved it into a new issue here: https://github.com/wbrawner/SimpleMarkdown/issues/38