search

wdecoster / chopper

MIT License
135 stars 11 forks source link

Make use of faster preset and multithreaded minimap2 #26

Closed Ge0rges closed 5 months ago

Ge0rges commented 5 months ago

Switched to using the new version of minimap2 which has the new LrHq preset and multithreading.

Make use of that 4x faster preset. Implement multithreading (I think it works?) for #18

wdecoster commented 5 months ago

Thank you @Ge0rges! Looks mostly okay, but the automated test reported two errors. Could you take a look at it? If necessary, I can help :)

Ge0rges commented 5 months ago

Checking it out right now

Ge0rges commented 5 months ago

@wdecoster should work now, I forgot to update the test functions.

wdecoster commented 5 months ago

Looks good! At some point, we should probably deal with the warning here: https://github.com/wdecoster/chopper/actions/runs/8317985884/job/22759454860?pr=26#step:4:128

Ge0rges commented 5 months ago

Yeah I wasn't sure what that was about so I decided to leave it be for now.

Ge0rges commented 5 months ago

It might be worth mentioning somewhere that we use LrHq in case someone is still using older chemistry.

Ge0rges commented 5 months ago

@wdecoster do you think the PR merits a version bump and package?

wdecoster commented 4 months ago

Yes, I need to make a new release. Hmm, the older chemistry won't immediately go away. I am not yet sure what the best solution is.