weavejester / crypto-keystore

Clojure library for dealing with Java keystores
9 stars 1 forks source link

Hope these functions can be usefull #1

Open igumus opened 10 years ago

igumus commented 10 years ago
weavejester commented 10 years ago

Thanks for the pull requesut, but there are a few issues:

  1. The pull request should have a descriptive title
  2. The pull request should be for a single change, not two.
  3. In a git commit message, the first line should be a short summary of the changes.
  4. Functions should aim to do one thing. So your changes to keystore should be a separate function (perhaps load-keystore).
  5. Rather than having many functions to load different parts of the keystore into data, it might be better to have one function to transform a keystore into a map.
igumus commented 10 years ago

Added some functions to load keystore as clojure map and load an existing keystore.

igumus commented 10 years ago

Thanks for advices.

igumus commented 10 years ago

One question about your message; is this changes useful for project ???