search

weavejester / medley

A lightweight library of useful Clojure functions
Eclipse Public License 1.0
865 stars 66 forks source link

Allow records as param in mapping coll functions #26

Closed rackdon closed 5 years ago

rackdon commented 6 years ago

Solves the issue #24 map-vals, map-keys & map-kv raise an exception when called on a record

I was thinking about convert the result again into a record but it has no sense if we modify the keys of the object, so at the end I have prefered return the result as a simple map

weavejester commented 6 years ago

I think the idea is sound, but why didn't you put the check into reduce-map instead of copy-pasting it?

rackdon commented 6 years ago

Oops, you're right. Changed following your comment

weavejester commented 6 years ago

Sorry about the late reply - the notification slipped through my inbox. Can you fix the indentation of the code and add an ending period to the commit message body (after "true")? If you don't have time I'll see about editing it myself, but that always messes up Github's PR to commit tracking.

weavejester commented 5 years ago

Merged manually.