search

weavejester / medley

A lightweight library of useful Clojure functions
Eclipse Public License 1.0
865 stars 66 forks source link

Deep-merge? #30

Closed vemv closed 5 years ago

vemv commented 5 years ago

Hi James,

what would be your thoughts on adding deep-merge? Seems a pretty common need.

https://github.com/r0man/noencore/blob/24ac307f132ec3e72f8dd133fc417ec734458a1e/src/no/en/core.cljc#L274 looks fine - simply I'd rather consume just one "utils" library than n.

weavejester commented 5 years ago

I think I'd be fine with that. I've had to implement a deep-merge myself at some point. However, I'd like to ensure that the function is as efficient as we can make it - I think we can improve on the implementation you linked.

vemv commented 5 years ago

Nice one, thank you!