search

weavejester / medley

A lightweight library of useful Clojure functions
Eclipse Public License 1.0
865 stars 66 forks source link

Add deps.edn #42

Closed borkdude closed 4 years ago

borkdude commented 4 years ago

While not strictly necessary, adding a deps.edn to your project will make it easier to use medley as a git dep using tools.deps.

weavejester commented 4 years ago

You've got a .gitignore change in there. Also, should the deps.edn have a Clojure dependency rather than being blank?

borkdude commented 4 years ago

@weavejester The .gitignore change goes hand in hand with working with deps.edn I'd say, but I can remove it if you wish.

An empty map is sufficient. It doesn't need a default Clojure version, unless you want to specify a minimum version.

weavejester commented 4 years ago

Ah, is .cpcache for the deps.edn toolchain? I assumed it was something leftover from an editor or IDE.

I think we should mimic the project.clj file and add a Clojure version, since Medley requires a minimum of Clojure 1.9.

weavejester commented 4 years ago

Thanks! Can you squash (well, fixup) your two commits into one?

borkdude commented 4 years ago

@weavejester I can do that, but why aren't you just using the Github "squash and merge" option for that?

Screenshot 2020-01-28 15 24 41

weavejester commented 4 years ago

Because that option discards the merge commit, at least last I checked.

borkdude commented 4 years ago

Done.