search

weavejester / medley

A lightweight library of useful Clojure functions
Eclipse Public License 1.0
865 stars 66 forks source link

Remove the use of 'the' in assoc-some docstring #49

Closed mbutlerw closed 4 years ago

mbutlerw commented 4 years ago

Apologies James, I chose to edit my commit and do a force push to my fork, in an attempt to preserve the original pull request's discussion. It was unaware that this automatically closes the pull request, lesson learnt.

Hope this isn't an issue, thanks for taking the time to review this.

Link to the original PR: https://github.com/weavejester/medley/pull/48

weavejester commented 4 years ago

I chose to edit my commit and do a force push to my fork, in an attempt to preserve the original pull request's discussion. It was unaware that this automatically closes the pull request

It shouldn't do... Are you using GitHub's client or something? You can also just reopen the PR, I believe.

The commit looks good, anyway. Can you change the commit message to:

Update assoc-some docstring for clarity
mbutlerw commented 4 years ago

I chose to edit my commit and do a force push to my fork, in an attempt to preserve the original pull request's discussion. It was unaware that this automatically closes the pull request

It shouldn't do... Are you using GitHub's client or something? You can also just reopen the PR, I believe.

The commit looks good, anyway. Can you change the commit message to:

Update assoc-some docstring for clarity

I think it was because I first pushed the repo with the commit removed, and Github doesn't allow a pull request with no changes.

Updated commit message as per your suggestion.

weavejester commented 4 years ago

Thanks, but the commit message body is still there. Can you remove that so it's a one-line commit message?

mbutlerw commented 4 years ago

No problem, misunderstood the request, should be a one-line commit message now.