search

weaveworks-plugins / scope-http-statistics

Plugin for Weave Scope which implements various HTTP statistics
Apache License 2.0
40 stars 19 forks source link

Add HTTP responses codes metric #2

Closed alepuccetti closed 7 years ago

alepuccetti commented 7 years ago

This metric shows in the UI the HTTP responses codes rate for those codes that are seen in the time interval where Scope UI shows historical data.

For convenience, I added the build-tools and the circle.yml to use cricleci and dockerhub.

This PR is rebased on https://github.com/weaveworks-plugins/scope-http-statistics/pull/1

@2opremio PTAL

alepuccetti commented 7 years ago

@2opremio This should be good to go too.

alepuccetti commented 7 years ago

@2opremio Updated

2opremio commented 7 years ago

LGTM (comments-aside). If possible I would like alban to sign-off the ebpf code (I am still a newbie myself).

alban commented 7 years ago

I reviewed the ebpf code before and it LGTM.

alepuccetti commented 7 years ago

@2opremio I addressed your comments and I also fixed a bug.

alepuccetti commented 7 years ago

This PR is relevant to https://github.com/weaveworks/scope/issues/1631

2opremio commented 7 years ago

This is good to go (as per my previous comment). @alepuccetti feel free to merge away!