weaveworks-plugins / scope-http-statistics

Plugin for Weave Scope which implements various HTTP statistics
Apache License 2.0
40 stars 19 forks source link

plugin socket directory is not removed if container stopped using docker stop #6

Closed alepuccetti closed 7 years ago

alepuccetti commented 7 years ago

When the plugin is stopped using docker stop or docker kill the socket directory /var/run/scope/plugins/http-statistics is not removed.

This has the effect to make scope believe that the plugin is active but not reachable.

alepuccetti commented 7 years ago

Close this issue because it was not a problem in the first place. This line takes care of it https://github.com/weaveworks-plugins/scope-http-statistics/blob/bca01fc8b636516e20edf3172531c1b6f79de46f/http-statistics.py#L189