Decouple reporting/tagging and publishing

weaveworks / scope

Monitoring, visualisation & management for Docker & Kubernetes

https://www.weave.works/oss/scope/

Apache License 2.0

5.87k stars 712 forks source link

Decouple reporting/tagging and publishing #932

Open 2opremio opened 8 years ago

2opremio commented 8 years ago

Following up on https://github.com/weaveworks/scope/issues/881#issuecomment-177698657:

we should have each one [tagger/publisher] on its own goroutine, trigger a report on the groutine, and then set a timeout for receiving results from them.

This will allow us to be more deadlock-resilient and do some analysis/detection of reporters/taggers taking longer than expected.

2opremio commented 8 years ago

Relevant code: https://github.com/weaveworks/scope/blob/c16f0d7f40091ea42071f79f915e1fe919e6c77c/probe/probe.go#L131-L164