search

web-illinois / toolkit

This library provides styles and web components for creating branded UIUC websites.
18 stars 7 forks source link

Site Title as H1 and more #94

Closed mwllr closed 3 years ago

mwllr commented 3 years ago

From Keith - Good catch! I can’t believe I missed that.
The department name should be an H1, along with the title in the page body.
The home page of a site should only have the H1 in the banner. The element in the <head> must be a combination of some of text in the H1 in the banner and that in the page body. Usually, it should be most specific to lease specific. To use the attached screen shot as an example, an appropriate title for the About page would be “About | Council on Teacher Education.”</p> <p>Another important point about heading use is that they should be visible in the page as a general rule. If it is not desired to have a visible heading for a page region, use aria-label instead. If there is not appropriate region or element in that spot for an aria-label, it is an indication that you either do not need a heading there or need to make it visible for all users.</p> <img width="1560" alt="Unknown" src="https://user-images.githubusercontent.com/54747669/120513198-a6244080-c391-11eb-9868-582f7621332e.png"> </div> </div> <div class="comment"> <div class="user"> <a rel="noreferrer nofollow" target="_blank" href="https://github.com/mattsharkey"><img src="https://avatars.githubusercontent.com/u/5148918?v=4" />mattsharkey</a> commented <strong> 3 years ago</strong> </div> <div class="markdown-body"> <p>Where does this need to be fixed? On this page, COTE is already an H1: <a href="https://cdn.brand.illinois.edu/toolkit/2.0/examples/components/header/multiple/index.html">https://cdn.brand.illinois.edu/toolkit/2.0/examples/components/header/multiple/index.html</a></p> </div> </div> <div class="comment"> <div class="user"> <a rel="noreferrer nofollow" target="_blank" href="https://github.com/bryanjonker-illinois"><img src="https://avatars.githubusercontent.com/u/65776851?v=4" />bryanjonker-illinois</a> commented <strong> 3 years ago</strong> </div> <div class="markdown-body"> <p>Talked with Keith, good to close</p> </div> </div> <div class="page-bar-simple"> </div> <div class="footer"> <ul class="body"> <li>© <script> document.write(new Date().getFullYear()) </script> Githubissues.</li> <li>Githubissues is a development platform for aggregating issues.</li> </ul> </div> <script src="https://cdn.jsdelivr.net/npm/jquery@3.5.1/dist/jquery.min.js"></script> <script src="/githubissues/assets/js.js"></script> <script src="/githubissues/assets/markdown.js"></script> <script src="https://cdn.jsdelivr.net/gh/highlightjs/cdn-release@11.4.0/build/highlight.min.js"></script> <script src="https://cdn.jsdelivr.net/gh/highlightjs/cdn-release@11.4.0/build/languages/go.min.js"></script> <script> hljs.highlightAll(); </script> </body> </html>